Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DB Migration docs #201

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Mythicaeda
Copy link
Contributor

Docs PR for NASA-AMMOS/aerie#1617.

Moves the old docs to an unlisted subpage that is linked from the updated docs (and links back to the updated docs).

- Move old docs to unlisted subpage
@Mythicaeda Mythicaeda added the documentation Improvements or additions to documentation label Dec 11, 2024
@Mythicaeda Mythicaeda requested a review from dandelany December 11, 2024 18:30
@Mythicaeda Mythicaeda self-assigned this Dec 11, 2024
Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good @Mythicaeda - just one change to an example command here (see related notes on the aerie PR here )

@@ -23,129 +28,57 @@ Alternatively, you can add the script to your `PATH` and run it from anywhere wi
export PATH="$HOME/path/to/deployment:$PATH"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment belongs on line 22 above, I can't put it there because Github...

This command python aerie_db_migration.py is no longer a valid call to the script due to the newly added subcommands - we should replace it with the new minimum command. Since I think some values from the env file are required, that would be something like aerie_db_migration.py migrate -e .env, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants